Skip to content

Fix typos in comments #9905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2018
Merged

Fix typos in comments #9905

merged 1 commit into from
Oct 19, 2018

Conversation

tnqn
Copy link
Contributor

@tnqn tnqn commented Oct 16, 2018

No description provided.

@willingc
Copy link
Contributor

Thanks @tnqn for the PR.

@vstinner What is the general feeling for PRs in the C code that are correct typos in comments? Merge or defer and update the comments when the underlying C code changes? Thanks.

@willingc willingc requested a review from vstinner October 16, 2018 04:59
@vstinner
Copy link
Member

@vstinner What is the general feeling for PRs in the C code that are correct typos in comments?

Merge them :-)

vstinner
vstinner approved these changes Oct 16, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@willingc: Do you want to merge it?

@vstinner vstinner merged commit 3bd0d62 into python:master Oct 19, 2018
@vstinner
Copy link
Member

Thanks @tnqn, I merged your PR!

@willingc
Copy link
Contributor

Thanks @tnqn for the PR and @vstinner for following up and the merge. 🍰

@bedevere-bot
Copy link

Hi! The buildbot AMD64 Windows7 SP1 3.x has failed when building commit 3bd0d62.

You can take a look here:

https://buildbot.python.org/all/#builders/40/builds/1027

@bedevere-bot
Copy link

Hi! The buildbot AMD64 Windows7 SP1 3.x has failed when building commit 3bd0d62.

You can take a look here:

https://buildbot.python.org/all/#builders/40/builds/1029

@tnqn tnqn deleted the typo branch October 21, 2018 14:37
@vstinner
Copy link
Member

Hi! The buildbot AMD64 Windows7 SP1 3.x has failed when building commit 3bd0d62.

The failure is unrelated to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tnqn @willingc @vstinner @bedevere-bot @the-knights-who-say-ni