gh-84976: Add _pydatetime module (Python datetime impl) #99090
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linking gh issue: #84976 |
AlexWaygood
changed the title
It's in the PR title and a link was automatically added to the PR description, it wasn't enough? |
|
It was done right after my comment :)
|
Speedup import datetime by moving the Python implementation of the datetime module into a new Lib/_pydatetime.py file. * Define datetime.__all__ in Lib/datetime.py. * _pydatetime.py defines __name__ as 'datetime' for pickling. * TestModule.test_divide_and_round() now imports directly _pydatetime, since _divide_and_round() is no longer exported by the datetime module. * test_datetime also requires a fresh _pydatetime when loading pure_tests.
Oh ok, my commit title was outdated. I fixed it. |
|
I closed my PR, rationale: #84976 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speedup import datetime by moving the Python implementation of the datetime module into a new Lib/_pydatetime.py file.