test_typing: use all pickle protocols
#99154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
requested review from
gvanrossum,
Fidget-Spinner,
JelleZijlstra and
AlexWaygood
as code owners
AlexWaygood
approved these changes
Nov 6, 2022
|
Should this be backported? |
kumaraditya303
added
needs backport to 3.10
Yes! |
kumaraditya303
approved these changes
Nov 6, 2022
|
Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 6, 2022
(cherry picked from commit a0bc75e) Co-authored-by: Nikita Sobolev <[email protected]>
|
GH-99157 is a backport of this pull request to the 3.11 branch. |
|
GH-99158 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 6, 2022
(cherry picked from commit a0bc75e) Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Nov 6, 2022
(cherry picked from commit a0bc75e) Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Nov 6, 2022
(cherry picked from commit a0bc75e) Co-authored-by: Nikita Sobolev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on some other thing, I've noticed that this call does not use
protofrom here:cpython/Lib/test/test_typing.py
Lines 2896 to 2897 in 8feb7ab
I think it is a typo. Fixing it!