Skip to content

Testability / portability (and fastly invalidation on devguide) #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 7, 2016

Conversation

JulienPalard
Copy link
Member

I implemented some new flags to allow the script to be executed anywhere, which is necessary for me to test it locally:

  • --log-directory: To log outside of /var/logs/ when testing locally
  • --group: To chgrp to someone else than "docs" when testing locally
  • --git: To use git instead of mercurial
  • `--skip-cache-invalidation: To avoid calling PURGE on fastly (which are probably just ignored).

Obviously the new options have production-ready default values, so it's again a drop-in replacement: no salt modification needed.

I also resolved the TODO about implementing fastly cache invalidation on the devguide.

CC @ewdurbin

@ewdurbin ewdurbin merged commit 54724b2 into python:master Dec 7, 2016
@ewdurbin
Copy link
Member

ewdurbin commented Dec 8, 2016

@JulienPalard this appears to have caused issues with the devguide. i'm investigating, but see python/devguide#79

@ewdurbin
Copy link
Member

ewdurbin commented Dec 8, 2016

fixed via ff091ee

@JulienPalard
Copy link
Member Author

D'oh sry for this, don't hesitate to HL me on IRC for this kind of situation, I do not so often look at my github and I missed your comment.

@JulienPalard JulienPalard deleted the portability branch December 10, 2016 20:46
@JulienPalard
Copy link
Member Author

Look like the doc is no longer up-to-date, this pull request may have broken something, can someone take a look on what's happening on the server? I have no access. ping @ewdurbin

@ewdurbin
Copy link
Member

@JulienPalard taking a look. thanks for the flag.

@ewdurbin
Copy link
Member

@JulienPalard here's some info from recent logs: https://gist.github.com/ewdurbin/69a31c2b6844a4275f99f32ae4e32740

I don't see any errors.

@ned-deily
Copy link
Member

ned-deily commented Dec 15, 2016

Looking at the build directory, it appears that the docs are being rebuilt. I think it's just a CDN caching issue. In the log, there is a CDN purge of the devguide trees but I didn't see any for the Python doc set trees, like https://docs.python.org/3.6/, ../3.7, ../2.7/, and the aliases to them ../3/. ../2/, ../dev/ etc etc. Perhaps the whole docs.python.org should be purged regularly? I manually purged a few of the index.html URLs and the contents did update.

@JulienPalard
Copy link
Member Author

@ned-deily Historically only python builds (like /2.7/, /3.5/, ..) were purged. This PR (see title) introduces purge on devguide. We still have to work on aliases, that looks manually done (don't remember if I searched but I think so, and I think I not found them in salt scripts, so they may have been done manually).

Look like this PR broke the cache invalidation for python builds. I typically test this script locally with "--skip-cache-invalidation", so I may have missed a bug about it. I'll investigate soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants