[mypyc] Foundational support for tuple literals (+ None and bool) #10041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
added a commit
that referenced
this pull request
Feb 27, 2021
This adds back #10041 that was reverted because of failing Windows builds. original PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for loading tuple literals using
LoadLiteral. The literal tuple objects willbe constructed during module import time, similar to other literals. Only tuples containing
items of supported literal types can be represented (this includes other tuples).
Add
None,TrueandFalseto the literals array so that they can be used as tupleliteral items.
Currently tuple literals aren't used for anything. I added some unit tests to check parts
of the implementation.
The primary use case I have in mind is supporting vectorcall APIs which expect a tuple
of keyword argument names. I will implemented this in a separate PR. This will also add
some end-to-end testing for tuple literals.
These could be used to avoid repeatedly constructing tuples with literal values in other
contexts as well.
Use array-based encoding for tuple literal values. We use the literal object array introduced
in #10040 to allow a simple integer-based encoding of heterogeneous tuples. For example,
tuple
('x', 5)could be encoded like this as three integers:'x')5)