[mypyc] Support various number-related dunders #10679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unify the interfaces of emitting unbox and cast operations. Also increase abstraction level by adding classes that describe failure handling, instead of passing C fragments used to handle errors.
msullivan
approved these changes
Jun 20, 2021
mypyc/codegen/emitwrapper.py
Outdated
| wrapper_name = gen.wrapper_name() | ||
|
|
||
| gen.emit_header() | ||
| if fn.name not in reverse_op_methods and fn.name in reverse_op_methods.values(): |
There was a problem hiding this comment.
It doesn't really matter but let's make a set in operators with the results of reverse_op_methods.values() so we don't need to scan
| if typ.is_unboxed: | ||
| # Borrow when unboxing to avoid reference count manipulation. | ||
| emitter.emit_unbox('obj_{}'.format(name), 'arg_{}'.format(name), typ, | ||
| error_code, declare_dest=True, borrow=True, optional=optional) | ||
| emitter.emit_unbox('obj_{}'.format(name), |
There was a problem hiding this comment.
I am not asking for a change, but just making a remark: I've really come around to "black-style" for multi-line function calls, where you put the first argument on a new line, indented four spaces
| optional=optional) | ||
|
|
||
|
|
||
| class WrapperGenerator: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for these unary dunders:
__neg____invert____int____float__Also add support for binary, reversible dunders, such as
__add__and__radd__.Finally, add support for in-place operator dunders such as
__iadd__.The semantics of the binary dunders don't always match Python semantics, but
many common use cases should work.
There is one significant difference from Python that is not easy to remove: if a
forward dunder method is called with an incompatible argument, it's treated the
same as if it returned
NotImplemented. This is necessary since the body ofthe method is never reached on incompatible argument type and there is no
way to explicitly return
NotImplemented. However, it's still recommended thatthe body returns
NotImplementedas expected for Python compatibility.If a dunder returns
NotImplementedand has a type annotation, the returntype should be annotated as
Union[T, Any], whereTis the return valuewhen
NotImplementedis not returned.Work on mypyc/mypyc#839.