Skip to content

[mypyc] Delete outdated TODOs #10698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2021
Merged

[mypyc] Delete outdated TODOs #10698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions mypyc/irbuild/ll_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1083,8 +1083,6 @@ def matching_call_c(self,
args: List[Value],
line: int,
result_type: Optional[RType] = None) -> Optional[Value]:
# TODO: this function is very similar to matching_primitive_op
# we should remove the old one or refactor both them into only as we move forward
matching = None # type: Optional[CFunctionDescription]
for desc in candidates:
if len(desc.arg_types) != len(args):
Expand Down
1 change: 0 additions & 1 deletion mypyc/test-data/run-functions.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ def fib(n: int) -> int:
return 1
else:
return fib(n - 1) + fib(n - 2)
return 0 # TODO: This should be unnecessary
[file driver.py]
from native import fib
print(fib(0))
Expand Down