bpo-45122: Remove PyCode_New from mypyc #11067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -189,38 +189,6 @@ void CPy_TypeError(const char *expected, PyObject *value) { | |||
| } | |||
| } | |||
|
|
|||
| // These functions are basically exactly PyCode_NewEmpty and | |||
| // _PyTraceback_Add which are available in all the versions we support. | |||
There was a problem hiding this comment.
This comment still applies to the next function I believe. Not sure what optimization this is talking about.
|
Note that this fixes mypy issue #11066. |
JelleZijlstra
approved these changes
Sep 7, 2021
gvanrossum
approved these changes
Sep 16, 2021
|
Thanks! Now I can sleep at night. :-) |
|
Always happy to be of service. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Guido plans to remove PyCode_New from CPython CAPI.
See: https://bugs.python.org/issue45122
closes: #11066