Skip to content

Optimize CallableType.formal_arguments #11543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions mypy/types.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

from typing import (
Any, TypeVar, Dict, List, Tuple, cast, Set, Optional, Union, Iterable, NamedTuple,
Sequence, Iterator
Sequence
)
from typing_extensions import ClassVar, Final, TYPE_CHECKING, overload, TypeAlias as _TypeAlias

Expand Down Expand Up @@ -1168,14 +1168,15 @@ def max_possible_positional_args(self) -> int:
return sys.maxsize
return sum([kind.is_positional() for kind in self.arg_kinds])

def formal_arguments(self, include_star_args: bool = False) -> Iterator[FormalArgument]:
def formal_arguments(self, include_star_args: bool = False) -> List[FormalArgument]:
"""Yields the formal arguments corresponding to this callable, ignoring *arg and **kwargs.

To handle *args and **kwargs, use the 'callable.var_args' and 'callable.kw_args' fields,
if they are not None.

If you really want to include star args in the yielded output, set the
'include_star_args' parameter to 'True'."""
args = []
done_with_positional = False
for i in range(len(self.arg_types)):
kind = self.arg_kinds[i]
Expand All @@ -1186,11 +1187,14 @@ def formal_arguments(self, include_star_args: bool = False) -> Iterator[FormalAr

required = kind.is_required()
pos = None if done_with_positional else i
yield FormalArgument(
arg = FormalArgument(
self.arg_names[i],
pos,
self.arg_types[i],
required)
required
)
args.append(arg)
return args

def argument_by_name(self, name: Optional[str]) -> Optional[FormalArgument]:
if name is None:
Expand Down