Factor out field_makers alongside dataclass_makers #11584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Nov 21, 2021
mypy/plugins/dataclasses.py
Outdated
| @@ -20,10 +20,15 @@ | |||
| from mypy.server.trigger import make_wildcard_trigger | |||
|
|
|||
| # The set of decorators that generate dataclasses. | |||
| dataclass_makers: Final = { | |||
| dataclass_makers = { | |||
There was a problem hiding this comment.
Why do you want to remove Final here?
There was a problem hiding this comment.
Just because I am editing it like so: https://github.com/NeilGirdhar/tjax/blob/master/tjax/mypy_plugin.py#L8
(This surprisingly works!)
But I'm happy to revert that change if it makes you uncomfortable.
There was a problem hiding this comment.
Oh I see 🙂
There's no need to remove Final when mutating a variable. Only reassignment is forbidden with Final.
So, mypy.plugins.dataclasses.dataclass_makers.add('tjax._src.dataclasses.dataclass.dataclass') is fine. And mypy.plugins.dataclasses.dataclass_makers = [] not.
There was a problem hiding this comment.
Ah! Thanks for setting me straight on that. I will re-add Final now.
JelleZijlstra
approved these changes
Nov 22, 2021
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a very minor change that moves the
field_makersconstant up to the global scope.Currently, I have duplicated this entire plugin here https://github.com/NeilGirdhar/tjax/blob/master/tjax/mypy_plugin.py, but it keeps changing.
I would like to simply add my custom dataclass and its field maker to the constant sets, and having them in the global scope (and non-final) makes that easy.