Skip tests that depend on lxml if not installed #12813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
JukkaL
approved these changes
May 19, 2022
hauntsaninja
added a commit
to hauntsaninja/mypy
that referenced
this pull request
Jul 15, 2022
See mypyc/mypy_mypyc-wheels#35 for motivation We also need fewer lxml workarounds, since python#12813 skips lxml tests if needed This is a bit of a pain to test since the script was moved into the mypy repo from the wheels repo
hauntsaninja
added a commit
that referenced
this pull request
Jul 16, 2022
See mypyc/mypy_mypyc-wheels#35 for motivation We also need fewer lxml workarounds, since #12813 skips lxml tests if needed This is a bit of a pain to test since the script was moved into the mypy repo from the wheels repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Detect if
lxmlis importable in the test suite, if it is not, then skip the report tests which depend on it.This is useful for enabling CI on new Python versions that may not have lxml wheels yet.
Test Plan
To test this I uninstalled
lxmland was able to seepytest mypy/test/testcheck.py::TypeCheckSuite::check-reports.testskip all the tests.Closes #11662