Skip to content

Remove unnecessary max call for python version in test_run.py #12848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions mypyc/test/test_run.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,11 +174,7 @@ def run_case_step(self, testcase: DataDrivenTestCase, incremental_step: int) ->
options.use_builtins_fixtures = True
options.show_traceback = True
options.strict_optional = True
# N.B: We try to (and ought to!) run with the current
# version of python, since we are going to link and run
# against the current version of python.
# But a lot of the tests use type annotations so we can't say it is 3.5.
options.python_version = max(sys.version_info[:2], (3, 6))
options.python_version = sys.version_info[:2]
options.export_types = True
options.preserve_asts = True
options.incremental = self.separate
Expand Down