Skip to content

stubtest: use single line error message #13301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2022
Merged

stubtest: use single line error message #13301

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
963265b
stubtest: use single line error message
hauntsaninja Aug 1, 2022
5242b92
Update mypy/stubtest.py
hauntsaninja Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions mypy/stubtest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,8 @@ def verify(
def _verify_exported_names(
object_path: List[str], stub: nodes.MypyFile, runtime_all_as_set: Set[str]
) -> Iterator[Error]:
# note that this includes the case the stub simply defines `__all__: list[str]`
assert "__all__" in stub.names
public_names_in_stub = {m for m, o in stub.names.items() if o.module_public}
names_in_stub_not_runtime = sorted(public_names_in_stub - runtime_all_as_set)
names_in_runtime_not_stub = sorted(runtime_all_as_set - public_names_in_stub)
Expand All @@ -254,16 +256,13 @@ def _verify_exported_names(
yield Error(
object_path,
(
"module: names exported from the stub "
"do not correspond to the names exported at runtime.\n"
"(Note: This is probably either due to an inaccurate "
"`__all__` in the stub, "
"or due to a name being declared in `__all__` "
"but not actually defined in the stub.)"
"names exported from the stub do not correspond to the names exported at runtime. "
"This is probably due to an inaccurate `__all__` in the stub or things being missing from the stub."
),
# pass in MISSING instead of the stub and runtime objects,
# as the line numbers aren't very relevant here,
# and it makes for a prettier error message.
# Pass in MISSING instead of the stub and runtime objects, as the line numbers aren't very
# relevant here, and it makes for a prettier error message
# This means this error will be ignored when using `--ignore-missing-stub`, which is
# desirable in at least the `names_in_runtime_not_stub` case
stub_object=MISSING,
runtime_object=MISSING,
stub_desc=(
Expand Down