typeanal: add error codes for many errors #13550

hauntsaninja · 2022-08-28T21:57:08Z

I only added codes that I was fairly confident about

hauntsaninja · 2022-08-28T23:04:10Z

Hmm, mypy self check is fine, but the mypyc build fails. E.g., you can minimise this to:

λ git diff | cat            
Alias tip: gd | cat
diff --git a/mypy/message_registry.py b/mypy/message_registry.py
index 1b58f56d8..b6f49baab 100644
--- a/mypy/message_registry.py
+++ b/mypy/message_registry.py
@@ -26,6 +26,7 @@ class ErrorMessage(NamedTuple):
 
 
 # Invalid types
+ASDF: Final = ErrorMessage("yikes", codes.VALID_TYPE)
 INVALID_TYPE_RAW_ENUM_VALUE: Final = "Invalid type: try using Literal[{}.{}] instead?"
 
 # Type checker error message constants

λ mypy --config-file mypy_self_check.ini -p mypy -p mypyc     
Success: no issues found in 264 source files

λ CC=clang MYPYC_OPT_LEVEL=0 python3 setup.py --use-mypyc build_ext --inplace          
mypy/message_registry.py:29: error: Cannot determine type of "VALID_TYPE"

JukkaL

Thanks, looks good overall. Left comments about uses of the type-var error code, which didn't feel quite right to me.

JukkaL · 2022-09-07T09:50:39Z

mypy/typeanal.py

@@ -281,11 +281,13 @@ def visit_unbound_type_nonoptional(self, t: UnboundType, defining_literal: bool)
            tvar_def = self.tvar_scope.get_binding(sym)
            if isinstance(sym.node, ParamSpecExpr):
                if tvar_def is None:
-                    self.fail(f'ParamSpec "{t.name}" is unbound', t)
+                    self.fail(f'ParamSpec "{t.name}" is unbound', t, code=codes.TYPE_VAR)


This arguably goes against the description of the error code: "Check that type variable values are valid". There's a similar existing use in checker.py which is also seems incorrect. Can we use valid-type here instead? We could add a new error code, such as typevar-bound (analogous to to name-defined), but this may be a little marginal for a dedicated error code.

JukkaL · 2022-09-07T09:55:50Z

mypy/typeanal.py

                    t,
+                    code=codes.TYPE_VAR,


Similar to above, valid-type seems better here (or falling back to misc).

JukkaL · 2022-09-07T09:56:32Z

mypy/typeanal.py

                    t,
+                    code=codes.TYPE_VAR,


Similar to above.

JukkaL · 2022-09-07T09:56:38Z

mypy/typeanal.py

                )
                return AnyType(TypeOfAny.from_error)
            if isinstance(sym.node, TypeVarTupleExpr):
                if tvar_def is None:
-                    self.fail(f'TypeVarTuple "{t.name}" is unbound', t)
+                    self.fail(f'TypeVarTuple "{t.name}" is unbound', t, code=codes.TYPE_VAR)


Similar to above.

JukkaL · 2022-09-07T09:57:34Z

mypy/typeanal.py

-                self.fail(f'Type variable "{name}" is bound by an outer class', defn)
+                self.fail(
+                    f'Type variable "{name}" is bound by an outer class', defn, code=codes.TYPE_VAR
+                )


Similar to above.

hauntsaninja · 2022-09-08T03:03:00Z

Thanks, I had based these off of the one in checker.py. Changed!

github-actions · 2022-09-08T03:30:05Z

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

typeanal: add error codes for many errors

74ad418

I only added codes that I was fairly confident about