Skip to content

Update isort to 5.11.5 #14735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2023
Merged

Update isort to 5.11.5 #14735

merged 2 commits into from
Feb 19, 2023

Conversation

cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented Feb 19, 2023

Release notes: https://github.com/PyCQA/isort/releases/tag/5.11.5

This resolves an issue with pre-commit and poetry which caused the pre-commit isort install to fail.

Edit: 5.12.0 requires Python 3.8

@cdce8p cdce8p changed the title Update isort to 5.12.0 Update isort to 5.11.5 Feb 19, 2023
@JelleZijlstra
Copy link
Member

I could get behind upgrading to 5.12.0 and documenting that you need a newer Python version to run it, but if 5.11.5 solves the problem we can just stick with it for now. 3.7 will go EOL in a few months and presumably we'll drop mypy support soon after.

@cdce8p
Copy link
Collaborator Author

cdce8p commented Feb 19, 2023

I could get behind upgrading to 5.12.0 and documenting that you need a newer Python version to run it, but if 5.11.5 solves the problem we can just stick with it for now. 3.7 will go EOL in a few months and presumably we'll drop mypy support soon after.

We don't use pre-commit for the CI runs (yet) and the tox environment for lint still uses Python 3.7.

- name: Formatting with Black + isort and code style with flake8
python: '3.7'
arch: x64
os: ubuntu-latest
toxenv: lint

Although it isn't difficult to change it to 3.8, let's stick with 5.11.5 for now. That's just a hotfix for the pre-commit / poetry issue.

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JelleZijlstra JelleZijlstra merged commit 007960c into python:master Feb 19, 2023
@cdce8p cdce8p deleted the update-isort branch February 19, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants