Lock test dependencies #16283
Merged
Lock test dependencies #16283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
sobolevn
reviewed
Oct 20, 2023
test-requirements.txt
Outdated
| # This file is autogenerated by pip-compile with Python 3.11 | ||
| # by the following command: | ||
| # | ||
| # pip-compile --output-file=test-requirements.txt --unsafe-package=typed-ast test-requirements.in |
There was a problem hiding this comment.
Why do we need --unsafe-package=typed-ast part?
There was a problem hiding this comment.
I mention this in PR description, it's completely arbitrary, passing this results in pip-compile locking setuptools which is desirable since setuptools has caused us CI failures in the past
sobolevn
reviewed
Oct 20, 2023
There was a problem hiding this comment.
I propose to instead use: --no-strip-extras --generate-hashes --allow-unsafe
--no-strip-extrassilences this warning:
WARNING: --strip-extras is becoming the default in version 8.0.0. To silence this warning, either use --strip-extras to opt into the new default or use --no-strip-extras to retain the existing behavior.
--allow-unsafeis enough to have these line in lock file:
# The following packages are considered to be unsafe in a requirements file:
setuptools==68.2.2 \
--hash=sha256:4ac1475276d2f1c48684874089fefcd83bd7162ddaafb81fac866ba0db282a87 \
--hash=sha256:b454a35605876da60632df1a60f736524eb73cc47bbc9f3f1ef1b644de74fd2a
# via
# -r r.txt
# nodeenv
- Hashes are just great: less chance of MiM attack, etc
|
Thanks, I added points one and two. I didn't add hashes, I don't understand what the threat model would be for mypy's dev dependencies and I'm certainly not vetting provenance |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discussed in the contributor meetup today. This is a simple solution that requires very few changes. If you want to upgrade the lock file, you can pass
--upgradeor just delete it and regenerate.