fix: remove redundant .format()
#16288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* (fix): remove call to a `.format()` method for an f-string in the emit.py module.
nautics889
force-pushed
the
fix/miscellaneous-minor-fixes
branch
from
2665035 to
4ec451b
Compare
|
recheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.format()method for an f-string in the emit.py module.It looks like there is a redundant
.format()call for an f-string.Originally this was added in 040f3ab revision at 562th line.
I doubt there is any need to use
.format()when it's been formatted using the f-string simultaneously. (Although it's legal and isn't producing any exception or unexpected behaviour...)I didn't create a separate issue for this since it seems like a minor fix and does not affect behavior.