Raise custom error when builtin symbol is missing #2062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A common point of confusion people have when working on the mypy codebase is forgetting to include the appropriate builtin fixture to their unit tests. In particular, not including a fixture (or the right fixture) can result in a cryptic exception when the code attempts to look up the builtin symbol and fails. This commit adds a check to the most common failure point and raises a custom exception when it detects a builtin symbol is missing (which should never happen when running mypy normally).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common point of confusion people have when working on the mypy codebase is forgetting to include the appropriate builtin fixture to their unit tests. In particular, not including a fixture (or the right fixture) can result in a cryptic exception when the code attempts to look up the builtin symbol and fails.
This commit adds a check to the most common failure point and raises a custom exception when it detects a builtin symbol is missing (which should never happen when running mypy normally).