Accept ' ' as a valid format specifier name #2079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -70,7 +70,7 @@ def check_str_interpolation(self, str: StrExpr, replacements: Node) -> Type: | |||
| return self.named_type('builtins.str') | |||
|
|
|||
| def parse_conversion_specifiers(self, format: str) -> List[ConversionSpecifier]: | |||
| key_regex = r'(\((\w*)\))?' # (optional) parenthesised sequence of characters | |||
| key_regex = r'(\(([\w ]*)\))?' # (optional) parenthesised sequence of characters | |||
There was a problem hiding this comment.
Why not "anything except parentheses"? What does Python itself implement or document?
There was a problem hiding this comment.
The documentation doesn't specifically discuss this, but I tested all ASCII characters and everything except parentheses worked. I'll fix this up.
There was a problem hiding this comment.
OK, I already merged, so another PR will be needed.
There was a problem hiding this comment.
I decided to just change it. >_>
7c76609
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2058.