-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Support namedtuple as one of multiple superclasses #2091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks good to me, though there is one potential simplification. The |
|
…py, some refactoring
Yes - more refactoring. It helped me understand what happens, and I believe it makes the logic clearer. I can revert back to the minimal change if necessary. |
In the experimental refactor_to_enum branch I encountered what seems like another case of "Instance leak" we've discussed some time ago. I will try to investigate it; should I add the fix here or in a different PR? |
If it seems unrelated to this change, it's probably better create a new PR. |
The new methods don't really make the code easier for me to read. I'd suggest reverting to having them inline instead, as they are sufficiently simple. |
I would have opened an issue for the error, but it's hard to reproduce; in that branch there are many occurrences of the type, with similar context, and the error only occur in one of them. The current patch fixes the error, but I don't think it addresses the root of the problem. |
Okay if it's hard to isolate then no problem. |
Thanks! |
Solve issue #1558 by delegate subtype checks on TupleType to fallback.
This does not solve #1485. I don't know why.