Add --disallow-subclassing-any flag
#2100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -770,6 +770,8 @@ def analyze_base_classes(self, defn: ClassDef) -> None: | |||
| self.fail("Cannot subclass NewType", defn) | |||
| base_types.append(base) | |||
| elif isinstance(base, AnyType): | |||
| if self.options.disallow_subclassing_any: | |||
There was a problem hiding this comment.
I think it would be nice if this reported the name of the base class that's Any. You can probably extract that from base_expr at least in simple cases. Extra points if you can also report the module from it was imported (but I'm not sure if that info is easily available by the time we get here).
There was a problem hiding this comment.
@gvanrossum -- whoops, I must have overlooked this comment! I've pushed a new diff that reports the name when possible. Though, as you suspected, finding the module the base class was imported from was somewhat tricky.
If you'd like, I can make the error message even more descriptive and leave a brief note explaining possible causes of this error and potential fixes.
This commit adds a new flag that disallows classes from having a base class of type `Any`. This tends to happen when using `--silent-imports` or when using a class from a module or library that is not typechecked by mypy. Normally, mypy will silently accept subclassing Any, which can sometimes lead to discrepencies which further leads to subtle bugs. Passing in this optional flag will raise an error instead.
This commit modifies the error message to try and report the specific name of the invalid class whenever possible.
Michael0x2a
force-pushed
the
add-flag-disallowing-subclassing-any
branch
from
546cd17 to
bd6ae1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new flag that disallows classes from having a base class of type
Any.This tends to happen when using
--silent-importsor when using a class from a module or library that is not typechecked by mypy. Normally, mypy will silently accept subclassing Any, which can sometimes lead to discrepancies which further leads to subtle bugs.Passing in this optional flag will raise an error instead.