Skip to content

Fix crash on name collision for self attributes #3700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2017

Conversation

ilevkivskyi
Copy link
Member

Fixes #3687 (fixes both the crash and the underlying name resolution issue).

The fix is quite simple, I also noticed that normalized flag for symbol table nodes was not serialized, so I added this too.

@ilevkivskyi
Copy link
Member Author

I just realized that in my tests the relevant cache is not read, so that I added one more incremental test.

Copy link
Member

@emmatyping emmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Everything related to this that I threw at it worked.

@gvanrossum gvanrossum merged commit f127e2c into python:master Jul 12, 2017
@gvanrossum
Copy link
Member

Thanks for the fix, and thanks Ethan for the thorough testing!

@ilevkivskyi ilevkivskyi deleted the fullname-crash branch July 18, 2017 20:53
@gvanrossum gvanrossum mentioned this pull request Jul 18, 2017
gvanrossum pushed a commit that referenced this pull request Jul 18, 2017
Fixes #3687 (fixes both the crash and the underlying name resolution issue).

The fix is quite simple, I also noticed that normalized flag for symbol table nodes was not serialized, so I added this too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mypy returns invalid type: "bytes" in classes that define a bytes instance attribute
3 participants