With disallow_untyped_defs, warn for missing return types on async def #4218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes python#4209. Under disallow_untyped_defs, we were missing errors for missing return types on async def functions, because the return type of such functions is Awaitable[Any] instead of Any. This PR also removes a duplicate test case (apparently from the fast parser cleanup) and adds some missing annotations to stubs.
JelleZijlstra
force-pushed
the
fix4209
branch
from
b782a77 to
8895d18
Compare
JukkaL
approved these changes
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4209.
Under disallow_untyped_defs, we were missing errors for missing return
types on async def functions, because the return type of such functions
is Awaitable[Any] instead of Any.
This PR also removes a duplicate test case (apparently from the fast
parser cleanup) and adds some missing annotations to stubs.