Fix crashes in astdiff when sorting union items #7842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the snapshots could be unsortable, since the snapshot tuples could have inconsistent types. This attemps to make the types in tuples predictable based on the tuple prefix. More formally, consider these two snapshot tuples: (x1, ..., xn, xn+1, ...) (y1, ..., yn, yn+1, ...) If (x1, ..., xn) == (y1, ..., yn), xn+1 and yn+1 must be comparable. Attempt to fix #7834.
ilevkivskyi
approved these changes
Nov 1, 2019
| @@ -282,9 +292,9 @@ def visit_deleted_type(self, typ: DeletedType) -> SnapshotItem: | |||
|
|
|||
| def visit_instance(self, typ: Instance) -> SnapshotItem: | |||
| return ('Instance', | |||
| typ.type.fullname(), | |||
| encode_optional_str(typ.type.fullname()), | |||
There was a problem hiding this comment.
Doesn't this mean there is a bug elsewhere? Maybe we shouldn't mask it (especially if there is no repro)?
There was a problem hiding this comment.
I think that this is not a great place to detect the bug, since the traceback won't tell much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the snapshots could be unsortable, since the snapshot
tuples could have inconsistent types. This attemps to make the types
in tuples predictable based on the tuple prefix.
More formally, consider these two snapshot tuples:
If
(x1, ..., xn)==(y1, ..., yn),xn+1andyn+1must becomparable.
Attempt to fix #7834.