[mypyc] Allow dots in group names #7941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Single-module groups will be given a dotted group name equal to the module name by default. A dot in a group name will put the group C extension at that path. Generated C could will also be placed in a directory corresponding to the full dotted name (still under the build directory). The direct motivation here is that bazel wants artifacts to be under the appropriate directory, but it is cleaner in general I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single-module groups will be given a dotted group name equal to the
module name by default.
A dot in a group name will put the group C extension at that
path. Generated C could will also be placed in a directory
corresponding to the full dotted name (still under the build
directory).
The direct motivation here is that bazel wants artifacts to be under
the appropriate directory, but it is cleaner in general I think.