Fix typechecking on Python 3.8 #7953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Python 3.8 ast stubs now (correctly!) indicate that a key in Dict can be None. Fix fastparse to deal with this. Really the typed_ast stubs should say this also.
ilevkivskyi
approved these changes
Nov 14, 2019
| for e in l: | ||
| exp = self.visit(e) | ||
| res.append(exp) | ||
| return res | ||
|
|
||
| def translate_expr_list(self, l: Sequence[AST]) -> List[Expression]: |
There was a problem hiding this comment.
Maybe you can use an overload instead?
@overload
def translate_expr_list(l: Sequence[AST]) -> List[Expression]: ...
@overload
def translate_expr_list(l: Sequence[Optional[AST]]) -> List[Optional[Expression]]: ...There was a problem hiding this comment.
I tried that first and it complained that they overlapped
There was a problem hiding this comment.
Hm, I think I remember having similar troubles with get_proper_types(). @Michael0x2a is this actually unsafe or maybe we can relax this somehow (I mean invariant generics in return types)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python 3.8 ast stubs now (correctly!) indicate that a key in Dict
can be None. Fix fastparse to deal with this. Really the typed_ast stubs
should say this also.