Couple obvious optimizations for type aliases #8099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
approved these changes
Dec 6, 2019
| @@ -2755,6 +2755,7 @@ def __init__(self, target: 'mypy.types.Type', fullname: str, line: int, column: | |||
| self.alias_tvars = alias_tvars | |||
| self.no_args = no_args | |||
| self.normalized = normalized | |||
| self._is_recursive = None # type: Optional[bool] | |||
There was a problem hiding this comment.
Add comment (mention that if non-None, this the cached value). Maybe also mention that this is manipulated by TypeAliasType, as otherwise a reader may be confused as not much is done here with this.
| is_recursive = self.alias._is_recursive | ||
| if is_recursive is None: | ||
| is_recursive = self.expand_all_if_possible() is None | ||
| self.alias._is_recursive = is_recursive |
There was a problem hiding this comment.
Add comment (we cache the value as an optimization).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
The effect of this it at the limit of precision on my laptop, but it looks like this gives around 1% speed-up (for cold runs).