Skip to content

Replace @abstractproperty usage in mypy #8310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Replace @abstractproperty usage in mypy #8310

merged 1 commit into from
Jan 21, 2020

Conversation

TH3CHARLie
Copy link
Collaborator

Following #7952 and #8066, since @abstractproperty is deprecated and stubgen no longer generates code with @abstractproperty, I think it is reasonable to remove its usage in mypy's own code.

@TH3CHARLie TH3CHARLie requested a review from JukkaL January 21, 2020 15:20
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Makes sense.

@ilevkivskyi ilevkivskyi merged commit 0e6e9c6 into python:master Jan 21, 2020
@TH3CHARLie TH3CHARLie deleted the replace-abstractproperty branch January 21, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants