Support unary op via CallC #8933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TH3CHARLie
commented
Jun 2, 2020
| @@ -131,13 +131,12 @@ def int_compare_op(op: str, c_func_name: str) -> None: | |||
| emit=simple_emit('{dest} = {args[0]} + {args[1]};')) | |||
|
|
|||
|
|
|||
| def int_unary_op(op: str, c_func_name: str) -> OpDescription: | |||
There was a problem hiding this comment.
Some thoughts: I think the original design somehow reflects or predicts what we are doing now
There was a problem hiding this comment.
Yeah, the new approach fits in very nicely here.
4 tasks
JukkaL
approved these changes
Jun 3, 2020
| @@ -131,13 +131,12 @@ def int_compare_op(op: str, c_func_name: str) -> None: | |||
| emit=simple_emit('{dest} = {args[0]} + {args[1]};')) | |||
|
|
|||
|
|
|||
| def int_unary_op(op: str, c_func_name: str) -> OpDescription: | |||
There was a problem hiding this comment.
Yeah, the new approach fits in very nicely here.
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related mypyc/mypyc#709, mypyc/mypyc#734
Support unary ops and provide
int_neg_opas an example.