[mypyc] Try to fix mypy mac build failure on Python 3.5 on Travis #9508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We may be building a mixed 32/64-bit binary, so restrict the maximum integer literal to what's supported on a 32-bit platform, since the same C code needs to compile on both 32-bit and 64-bit architectures. This will make some slicing operations a bit slower in 32/64-bit mode (Python 3.5 on mac).
ilevkivskyi
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may be building a mixed 32/64-bit binary, so restrict the maximum integer
literal to what's supported on a 32-bit platform, since the same C code
needs to compile on both 32-bit and 64-bit architectures.
This will make some slicing operations a bit slower in 32/64-bit mode
(Python 3.5 on mac only).
Work on #9500.