Skip to content

[mypyc] Fix type of for loop index register in for over range #9634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2020
Merged

[mypyc] Fix type of for loop index register in for over range #9634

merged 2 commits into from
Oct 25, 2020

Conversation

JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Oct 24, 2020

It sometimes was short int even though it should have been int.

@JukkaL
[mypyc] Fix type of for loop index register in for over range
5f237e6 
It sometimes was short int even though it should have been int.
@JukkaL JukkaL requested a review from TH3CHARLie October 24, 2020 18:54
TH3CHARLie
TH3CHARLie approved these changes Oct 25, 2020
View reviewed changes
Copy link
Collaborator

@TH3CHARLie TH3CHARLie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TH3CHARLie TH3CHARLie merged commit af99ebc into master Oct 25, 2020
@TH3CHARLie TH3CHARLie deleted the for-range-fix branch October 25, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TH3CHARLie TH3CHARLie TH3CHARLie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JukkaL @TH3CHARLie