[mypyc] Merge fast_isinstance_op and py_calc_meta_op #9662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
approved these changes
Nov 2, 2020
| } | ||
|
|
||
| static inline PyObject *CPy_CalculateMetaclass(PyObject *type, PyObject *o) { | ||
| return (PyObject *)_PyType_CalculateMetaclass((PyTypeObject *)type, o); |
There was a problem hiding this comment.
This use of casts is a good way to work around the pointer type mismatches, and it's not a problem if we can't inline this on non-C backends, since this isn't performance critical.
|
The issue: mypyc/mypyc#774 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates mypyc/mypyc#753
This PR merges two remaining misc ops.
The problem with these two is that they rely on inlined
PyTypeObject *cast during the call, while the casted object has already gone through a cast fromPyTypeObject *toPyObject *before the function call(due to the highly C-coupled design in some other parts of the IR).Thus, I think the best way(at least for now) is to use inline wrappers to merge these two ops, avoiding introducing over-complicated designs for only these two ops.