Skip to content

Fix path escaping bug in HTML report (GH8979) #9797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2020

Conversation

rhkleijn
Copy link
Contributor

Description

Fixes #8979

One-liner fix for path escaping bug in HTML report on windows.

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Are there any other places in this file where the same change would be beneficial?)

@rhkleijn
Copy link
Contributor Author

As far as I can tell, there are no obvious other places where the same change would be beneficial.

The fix is very specific to the conversion from a filename to a url, which only seems to happen in this particular line.
Since the fix is in the MemoryXmlReporter class which is used internally in the other XML-based reporters it however already extends to both --html-report and --xml-report.

@gvanrossum gvanrossum merged commit ac32495 into python:master Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path escaping bug in HTML report
2 participants