add pyclbr._Object #11151
Merged
add pyclbr._Object #11151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to python#3968
This comment has been minimized.
This comment has been minimized.
tungol
commented
Dec 11, 2023
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
Dec 12, 2023
stdlib/pyclbr.pyi
Outdated
| def __init__(self, module: str, name: str, file: str, lineno: int, parent: _Object | None) -> None: ... | ||
|
|
||
| class Class(_Object): | ||
| super: list[Class | str] | None |
There was a problem hiding this comment.
I know that you only moved it here: But this will have similar issues like children above, especially in the constructor. (I.e. super = ["foo"]; Class(..., super, ...) will fail.) We should probably use Sequence here and in the constructor, but no need to fix this in this PR, as it hasn't made problems so far.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #3968