Add global_context keyword to gdb.parse_and_eval in GDB stub.
#12269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
approved these changes
Jul 3, 2024
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
The type stubs are for gdb 12.1 which is the version shipped with Ubuntu 22.04. CI tests against ubuntu-latest, which is 22.04 at the moment. Now I'm wondering why this change didn't trip stubtest. There are more changes in later gdb versions than this. |
max-muoto
pushed a commit
to max-muoto/typeshed
that referenced
this pull request
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a change to the GDB stub which adds the
global_contextkeyword argument to thegdb.parse_and_evalfunction, as described in the documentation. This keyword argument got added in GDB 14.The fact this keyword argument is missing makes the lint run in a currently open Pwndbg PR fail.