Fix type for run_coroutine_threadsafe
#13498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeshardmind
force-pushed
the
run_coro_threadsafe
branch
from
e657753 to
463cdc3
Compare
This comment has been minimized.
This comment has been minimized.
AlexWaygood
reviewed
Feb 14, 2025
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
AlexWaygood
changed the title
run_coroutine_threadsafe
Xiddoc
pushed a commit
to Xiddoc/typeshed
that referenced
this pull request
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior typing here is too permissive, this is strictly checked against these two types at runtime. Attempting to pass a task or future, each of which are FutureLike to this API results in a runtime error.