improve codecs stubs #2114
Merged
improve codecs stubs #2114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Started out as progress towards python#1476, but I ended up fixing a few more things: - fixed the signature of _encode_type, which actually returns a pair, not a string - made some attributes into properties in order to prevent the descriptor protocol from turning them into methods - found a bug in CPython in the process (python/cpython#6779) I used the following test file to make sure these classes are now instantiable: ```python import codecs import io from typing import IO bio = io.BytesIO() cod = codecs.lookup('utf-8') codecs.StreamReaderWriter(bio, codecs.StreamReader, codecs.StreamWriter) codecs.StreamRecoder(bio, cod.encode, cod.decode, codecs.StreamReader, codecs.StreamWriter) ```
gvanrossum
approved these changes
Jun 11, 2018
| @@ -33,8 +34,8 @@ _encoded = bytes | |||
|
|
|||
There was a problem hiding this comment.
It's really too bad that this file uses all-lowercase names to indicate various type aliases. But maybe now's not the right time to fix that.
| @@ -2,6 +2,7 @@ | |||
| # https://docs.python.org/2/library/codecs.html and https://docs.python.org/3/library/codecs.html | |||
There was a problem hiding this comment.
Honestly the attribution comment does not belong here, nor does the value judgment.
| @@ -217,7 +227,49 @@ class StreamReaderWriter(TextIO): | |||
| def seek(self, offset: int, whence: int = ...) -> int: ... | |||
| def __enter__(self: _T) -> _T: ... | |||
| def __exit__(self, typ: Optional[Type[BaseException]], exc: Optional[BaseException], tb: Optional[types.TracebackType]) -> bool: ... | |||
| def __getattr__(self, name: str) -> Any: ... | |||
|
|
|||
| # These methods don't actually exist directly, but they are needed to satisfy the TextIO | |||
There was a problem hiding this comment.
Is there no way to introduce these through inheritance?
There was a problem hiding this comment.
They're abstract on the base classes, so we need to have them here to make these classes non-abstract. Maybe there's some class in io that we could inherit from, but that wouldn't be accurate either since this class doesn't inherit from those classes at runtime.
There was a problem hiding this comment.
OK, let's keep this (verbose) approach then.
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
Started out as progress towards python#1476, but I ended up fixing a few more things: - fixed the signature of _encode_type, which actually returns a pair, not a string - made some attributes into properties in order to prevent the descriptor protocol from turning them into methods - found a bug in CPython in the process (python/cpython#6779) I used the following test file to make sure these classes are now instantiable: ```python import codecs import io from typing import IO bio = io.BytesIO() cod = codecs.lookup('utf-8') codecs.StreamReaderWriter(bio, codecs.StreamReader, codecs.StreamWriter) codecs.StreamRecoder(bio, cod.encode, cod.decode, codecs.StreamReader, codecs.StreamWriter) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started out as progress towards #1476, but I ended up fixing a few more things:
I used the following test file to make sure these classes are now instantiable: