-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Simplify and correct many numeric unions #7906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -68,7 +68,7 @@ class Random(_random.Random): | |
def __init__(self, x: Any = ...) -> None: ... | ||
# Using other `seed` types is deprecated since 3.9 and removed in 3.11 | ||
if sys.version_info >= (3, 9): | ||
def seed(self, a: int | float | str | bytes | bytearray | None = ..., version: int = ...) -> None: ... # type: ignore[override] | ||
def seed(self, a: float | str | bytes | bytearray | None = ..., version: int = ...) -> None: ... # type: ignore[override] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one feels a little worse to me in terms of serving as documentation for random.seed, any objections to noqa? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, feel free to revert and add a |
||
else: | ||
def seed(self, a: Any = ..., version: int = ...) -> None: ... | ||
|
||
|
Uh oh!
There was an error while loading. Please reload this page.