Skip to content

fix: annotate pstats.FunctionProfile.ncalls as str #8712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 10, 2022
Merged

fix: annotate pstats.FunctionProfile.ncalls as str #8712

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e0a376
fix: annotate `pstats.FunctionProfile.ncalls` as `str`
ruancomelli Sep 8, 2022
37e3afc
Add comment pointing out the difference to CPython
ruancomelli Sep 10, 2022
da88318
Merge branch 'master' into ruancomellipstats-FunctionProfile-ncalls
ruancomelli Sep 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion stdlib/pstats.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ if sys.version_info >= (3, 9):

@dataclass(unsafe_hash=True)
class FunctionProfile:
ncalls: int
# Note: the annotation in the CPython codebase is "int", but the annotation in CPython is wrong! See #8712
ncalls: str
tottime: float
percall_tottime: float
cumtime: float
Expand Down