This repository was archived by the owner on Aug 7, 2024. It is now read-only.
Added initial compile tests for flat-parameter FSDP #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
added 2 commits
February 15, 2024 11:16
The tests added in this PR test (1) compile with `frame_count` to check that we are compiling the expected number of functions and (2) numerics against manual data parallelism (including using FSDP's mixed precision). These add ~42 seconds to the test time. There are existing tests in `test_fsdp.py` and `test_fsdp_compile.py`. I am not sure how we should consolidate. The tests in `test_fsdp_compile.py` seem somewhat obsolete since they do not test numerics. [ghstack-poisoned]
The tests added in this PR test (1) compile with `frame_count` to check that we are compiling the expected number of functions and (2) numerics against manual data parallelism (including using FSDP's mixed precision). These add ~42 seconds to the test time. There are existing tests in `test_fsdp.py` and `test_fsdp_compile.py`. I am not sure how we should consolidate. The tests in `test_fsdp_compile.py` seem somewhat obsolete since they do not test numerics. [ghstack-poisoned]
This was referenced Feb 16, 2024
added 2 commits
February 16, 2024 07:36
The tests added in this PR test (1) compile with `frame_count` to check that we are compiling the expected number of functions and (2) numerics against manual data parallelism (including using FSDP's mixed precision). These add ~42 seconds to the test time. There are existing tests in `test_fsdp.py` and `test_fsdp_compile.py`. I am not sure how we should consolidate. The tests in `test_fsdp_compile.py` seem somewhat obsolete since they do not test numerics. [ghstack-poisoned]
The tests added in this PR test (1) compile with `frame_count` to check that we are compiling the expected number of functions and (2) numerics against manual data parallelism (including using FSDP's mixed precision). These add ~42 seconds to the test time. There are existing tests in `test_fsdp.py` and `test_fsdp_compile.py`. I am not sure how we should consolidate. The tests in `test_fsdp_compile.py` seem somewhat obsolete since they do not test numerics. [ghstack-poisoned]
awgu
changed the title
The tests added in this PR test (1) compile with `frame_count` to check that we are compiling the expected number of functions and (2) numerics against manual data parallelism (including using FSDP's mixed precision). These add ~42 seconds to the test time. There are existing tests in `test_fsdp.py` and `test_fsdp_compile.py`. I am not sure how we should consolidate. The tests in `test_fsdp_compile.py` seem somewhat obsolete since they do not test numerics. [ghstack-poisoned]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
modulearg fromfsdp_pre_all_gather#217use_activation_hooks: boolto swap #214amax_and_scale_syncedunconditionally #220The tests added in this PR test (1) compile with
frame_countto check that we are compiling the expected number of functions and (2) numerics against manual data parallelism. We exclude checking activation checkpointing and FSDP's mixed precision in this PR.There are existing tests in
test_fsdp.pyandtest_fsdp_compile.py. I am not sure how we should consolidate. The tests intest_fsdp_compile.pyseem somewhat obsolete since they do not test numerics.