Skip to content

[oss-readiness] include pytest-asyncio and timeout #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
pip install pyzmq requests numpy pyre-extensions

# Test dependencies
pip install pytest cloudpickle
pip install pytest cloudpickle pytest-timeout pytest-asyncio

# Build and install monarch
python setup.py install
Expand Down
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,10 @@ sudo dnf install cuda-toolkit-12-0 cuda-12-0 libnccl-devel clang-devel
pip install setuptools-rust
# install torch, can use conda or build it yourself or whatever
pip install torch
# install other deps, see pyproject.toml for latest
pip install pyzmq requests numpy pyre-extensions pytest-timeout cloudpickle
# install core deps, see pyproject.toml for latest
pip install pyzmq requests numpy pyre-extensions cloudpickle
# Install test dependencies
pip install pytest pytest-timeout pytest-asyncio

# install the package
python setup.py install
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ authors = [
version = "1.0"
readme = "README.md"
description = "Monarch: Single controller library"
dependencies = ["torch", "pyzmq", "requests", "numpy", "pyre-extensions", "pytest-timeout", "cloudpickle"]
dependencies = ["torch", "pyzmq", "requests", "numpy", "pyre-extensions", "pytest-timeout", "cloudpickle", "pytest-asyncio"]
requires-python = ">= 3.10"

[tool.pytest.ini_options]
Expand Down