Skip to content

fix: Update broken repo hyperlink #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

lamhoangtung
Copy link
Contributor

Description

Hi, I'm looking in the new documentation over at https://pytorch.org/TensorRT/ and found some hyperlink broken for the torchtrt_runtime example and decided to do a quick PR to fix it.

I also found a bunch of old link to this repo and updated it with the new repo link under pytorch organization

Type of change

  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: core Issues re: The core compiler component: partitioning component: tests Issues re: Tests documentation Improvements or additions to documentation labels Jun 16, 2022
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you drop changes to //docs from this PR? Our CI will build a new version once its checked into master and it will make this PR much easier to review.

@lamhoangtung
Copy link
Contributor Author

Sure @narendasan. I just drop all changes to the docs directory.

@lamhoangtung lamhoangtung requested a review from narendasan June 17, 2022 01:35
@narendasan
Copy link
Collaborator

Hmm the docs changes are still around, can you drop any changes to docs and rebase on master? Or tt might be easier to do this on a new branch and open a new PR

@lamhoangtung
Copy link
Contributor Author

@narendasan. Seems like the changes to docs are autogenerated. Sure. Let me open a new PR

@lamhoangtung
Copy link
Contributor Author

@narendasan can you take a look at the new PR #1131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: core Issues re: The core compiler component: partitioning component: tests Issues re: Tests documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants