Skip to content

Use TensorRT 20.03 as base container for builds #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

shashank3959
Copy link
Contributor

Description

  • Change replaces pytorch 20.03 with tensorrt 20.03
    as base container for trtorch builds.

  • Adds locale setting as no locale was set by default leading to build failure.

Signed-off-by: Shashank Verma [email protected]

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation and have regenerated the documentation (make html in docsrc)
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

- Change replaces pytorch 20.03 with tensorrt 20.03
as base container for trtorch builds.

- Adds locale setting as no locale was set by default

Signed-off-by: Shashank Verma <[email protected]>
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending @vinhngx approval to merge.

@vinhngx
Copy link
Contributor

vinhngx commented Jul 23, 2020

Reassign to @mengdih to review. Thanks!

@mengdih
Copy link
Contributor

mengdih commented Jul 29, 2020

Reviewed, LGTM.

@narendasan narendasan merged commit 02abcaa into pytorch:master Jul 29, 2020
@shashank3959 shashank3959 deleted the cherry-branch branch August 3, 2020 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants