Skip to content

Lowering aten::pad to aten::constant_pad_nd/aten::reflection_padXd/aten::replication_padXd #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/lowering/lowering.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ void LowerGraph(std::shared_ptr<torch::jit::Graph>& g, std::vector<torch::jit::I
passes::UnpackAndCastFull(g, lower_info.getGPUDeviceString());
passes::ReplaceScalarImplicit(g);
passes::RewriteInputsWithParams(g, params);
passes::ReplaceAtenPad(g);
LOG_GRAPH(*g);
}

Expand Down
1 change: 1 addition & 0 deletions core/lowering/passes/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ cc_library(
"remove_dropout.cpp",
"remove_nops.cpp",
"remove_unnecessary_casts.cpp",
"replace_aten_pad.cpp",
"rewrite_inputs_with_params.cpp",
"silu_to_sigmoid_multiplication.cpp",
"unpack_addmm.cpp",
Expand Down
1 change: 1 addition & 0 deletions core/lowering/passes/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ target_sources(${lib_name}
"${CMAKE_CURRENT_SOURCE_DIR}/remove_nops.cpp"
"${CMAKE_CURRENT_SOURCE_DIR}/remove_set_attrs.cpp"
"${CMAKE_CURRENT_SOURCE_DIR}/remove_unnecessary_casts.cpp"
"${CMAKE_CURRENT_SOURCE_DIR}/replace_aten_pad.cpp"
"${CMAKE_CURRENT_SOURCE_DIR}/silu_to_sigmoid_multiplication.cpp"
"${CMAKE_CURRENT_SOURCE_DIR}/unpack_addmm.cpp"
"${CMAKE_CURRENT_SOURCE_DIR}/unpack_batch_norm.cpp"
Expand Down
1 change: 1 addition & 0 deletions core/lowering/passes/passes.h
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ void UnpackAndCastMaskedFill(std::shared_ptr<torch::jit::Graph>& graph, std::str
void UnpackAndCastNumToTensor(std::shared_ptr<torch::jit::Graph>& graph, std::string target_device_name);
void UnpackAndCastFull(std::shared_ptr<torch::jit::Graph>& graph, std::string target_device_name);
void ReplaceScalarImplicit(std::shared_ptr<torch::jit::Graph>& graph);
void ReplaceAtenPad(std::shared_ptr<torch::jit::Graph>& graph);

// utility functions exposed for testing
std::string unmangle_cls_name(const std::string& name);
Expand Down
125 changes: 125 additions & 0 deletions core/lowering/passes/replace_aten_pad.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,125 @@
#include <torch/csrc/jit/passes/subgraph_rewrite.h>

#include "core/util/prelude.h"

namespace torch_tensorrt {
namespace core {
namespace lowering {
namespace passes {

void ReplaceAtenPad(std::shared_ptr<torch::jit::Graph>& graph) {
for (auto it = graph->block()->nodes().begin(), end = graph->block()->nodes().end(); it != end; ++it) {
if (it->kind() == c10::Symbol::fromQualString("aten::pad")) {
// aten::pad(Tensor self, int[] pad, str mode='constant', float? value=None) -> (Tensor)
auto mode = it->inputs()[2];
if (mode->type()->isSubtypeOf(c10::StringType::get())) {
std::string mode_str = torch::jit::toIValue(mode)->to<std::string>();
if (mode_str == "reflect") {
auto pad = it->inputs()[1];
c10::List<int64_t> pad_list = torch::jit::toIValue(pad)->to<c10::List<int64_t>>();
if (pad_list.size() == 2) {
// aten::reflection_pad1d(Tensor self, int[2] padding) -> (Tensor)
torch::jit::Node* new_node;
new_node = graph->create(
c10::Symbol::fromQualString("aten::reflection_pad1d"),
torch::jit::ArrayRef<torch::jit::Value*>({it->inputs()[0], it->inputs()[1]}),
1);
new_node->insertAfter(*it);
new_node->outputs()[0]->setType(c10::TensorType::get());
it->outputs()[0]->replaceAllUsesWith(new_node->outputs()[0]);
auto pre = --it;
++it;
it->destroy();
it = pre;
} else if (pad_list.size() == 4) {
// aten::reflection_pad2d(Tensor self, int[4] padding) -> (Tensor)
torch::jit::Node* new_node;
new_node = graph->create(
c10::Symbol::fromQualString("aten::reflection_pad2d"),
torch::jit::ArrayRef<torch::jit::Value*>({it->inputs()[0], it->inputs()[1]}),
1);
new_node->insertAfter(*it);
new_node->outputs()[0]->setType(c10::TensorType::get());
it->outputs()[0]->replaceAllUsesWith(new_node->outputs()[0]);
auto pre = --it;
++it;
it->destroy();
it = pre;
} else if (pad_list.size() == 6) {
LOG_ERROR("Torch-TRT doesn't support aten::reflection_pad3d currently.");
}

} else if (mode_str == "replicate") {
auto pad = it->inputs()[1];
c10::List<int64_t> pad_list = torch::jit::toIValue(pad)->to<c10::List<int64_t>>();
if (pad_list.size() == 2) {
// aten::replication_pad1d(Tensor self, int[2] padding) -> (Tensor)
torch::jit::Node* new_node;
new_node = graph->create(
c10::Symbol::fromQualString("aten::replication_pad1d"),
torch::jit::ArrayRef<torch::jit::Value*>({it->inputs()[0], it->inputs()[1]}),
1);
new_node->insertAfter(*it);
new_node->outputs()[0]->setType(c10::TensorType::get());
it->outputs()[0]->replaceAllUsesWith(new_node->outputs()[0]);
auto pre = --it;
++it;
it->destroy();
it = pre;
} else if (pad_list.size() == 4) {
// aten::replication_pad2d(Tensor self, int[4] padding) -> (Tensor)
torch::jit::Node* new_node;
new_node = graph->create(
c10::Symbol::fromQualString("aten::replication_pad2d"),
torch::jit::ArrayRef<torch::jit::Value*>({it->inputs()[0], it->inputs()[1]}),
1);
new_node->insertAfter(*it);
new_node->outputs()[0]->setType(c10::TensorType::get());
it->outputs()[0]->replaceAllUsesWith(new_node->outputs()[0]);
auto pre = --it;
++it;
it->destroy();
it = pre;
} else if (pad_list.size() == 6) {
// aten::replication_pad3d(Tensor self, int[6] padding) -> (Tensor)
torch::jit::Node* new_node;
new_node = graph->create(
c10::Symbol::fromQualString("aten::replication_pad3d"),
torch::jit::ArrayRef<torch::jit::Value*>({it->inputs()[0], it->inputs()[1]}),
1);
new_node->insertAfter(*it);
new_node->outputs()[0]->setType(c10::TensorType::get());
it->outputs()[0]->replaceAllUsesWith(new_node->outputs()[0]);
auto pre = --it;
++it;
it->destroy();
it = pre;
}

} else if (mode_str == "constant") {
// aten::constant_pad_nd(Tensor self, int[] pad, Scalar value=0) -> (Tensor)
torch::jit::Node* new_node;
new_node = graph->create(
c10::Symbol::fromQualString("aten::constant_pad_nd"),
torch::jit::ArrayRef<torch::jit::Value*>({it->inputs()[0], it->inputs()[1], it->inputs()[3]}),
1);
new_node->insertAfter(*it);
new_node->outputs()[0]->setType(c10::TensorType::get());
it->outputs()[0]->replaceAllUsesWith(new_node->outputs()[0]);
auto pre = --it;
++it;
it->destroy();
it = pre;
} else if (mode_str == "circular") {
LOG_ERROR("Torch-TRT doesn't support circular padding currently.");
}
}
}
}
LOG_GRAPH("Post map aten::pad -> aten::constant_pad_nd/aten::reflection_padXd/aten::replication_padXd: " << *graph);
}

} // namespace passes
} // namespace lowering
} // namespace core
} // namespace torch_tensorrt
5 changes: 5 additions & 0 deletions tests/core/lowering/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,10 @@ lowering_test(
name = "test_rewrite_inputs_with_params",
)

lowering_test(
name = "test_replace_aten_pad_pass",
)

test_suite(
name = "lowering_tests",
tests = [
Expand All @@ -111,6 +115,7 @@ test_suite(
":test_remove_detach_pass",
":test_remove_dropout_pass",
":test_remove_unnecessary_casts",
":test_replace_aten_pad_pass",
":test_rewrite_inputs_with_params",
":test_unpack_hardsigmoid",
":test_unpack_hardswish",
Expand Down
Loading