Skip to content

Corrected typo causing error #1689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

Corrected typo causing error #1689

wants to merge 0 commits into from

Conversation

zshn25
Copy link
Contributor

@zshn25 zshn25 commented Feb 21, 2023

Added missing ** to unroll the TensorRTCompileSpec dict, which was causing an error

Description

Corrected a typo in the Using Torch-TensorRT Directly From PyTorch tutorial which was causing an error

Fixes #1688

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@facebook-github-bot
Copy link
Contributor

Hi @zshn25!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 21, 2023
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@github-actions github-actions bot requested a review from narendasan February 21, 2023 17:54
@narendasan
Copy link
Collaborator

@zshn25 thanks for catching this. Can you edit the doc source (docsrc/tutorials/use_from_pytorch.rst) instead of the HTML file since it will be regenerated

@zshn25
Copy link
Contributor Author

zshn25 commented Feb 22, 2023

@zshn25 thanks for catching this. Can you edit the doc source (docsrc/tutorials/use_from_pytorch.rst) instead of the HTML file since it will be regenerated

Created a new PR #1694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Tutorial Using Torch-TensorRT Directly From PyTorch raises KeyError
3 participants