Whole archive libs with registerers #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corresponding bazel flag is "alwayslink" Fixes pytorch#9 Signed-off-by: Junjie Bai <[email protected]>
bddppq
force-pushed
the
whole-archive-registerers
branch
from
507adcb to
6aeb2da
Compare
narendasan
approved these changes
Mar 20, 2020
frank-wei
pushed a commit
that referenced
this pull request
Jun 4, 2022
Summary: Pull Request resolved: pytorch/fx2trt#19 protocol is only in typing module after python 3.8 and we would want the minimum version requirement to be 3.7 (align with PyTorch and TensorRT). Reviewed By: brad-mengchi Differential Revision: D34896436 fbshipit-source-id: 71eea83c313d22f649715f1b4561f07df84f096e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corresponding bazel flag is "alwayslink"
Fixes #9