Fix stripping of apis from the final .so #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix (Thanks @bddppq for the pointer) Signed-off-by: Naren Dasan <[email protected]> Signed-off-by: Naren Dasan <[email protected]>
narendasan
added
component: api
frank-wei
pushed a commit
that referenced
this pull request
Jun 4, 2022
Summary: Pull Request resolved: pytorch/fx2trt#20 Adding the initial version of dispatch tracer for fx2trt. Mostly copied from functorch. Added leaf module support Removed decomposition support for this version for simplicity. Will add it. This version doesn't support trace size() as a node. Reviewed By: wushirong Differential Revision: D34868356 fbshipit-source-id: 52b34d8e3a34fd9209cd713363016259a735b866
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the library is full built the actual apis were getting stripped. Use alwayslink for both the core top level and api level to make sure they make it into the final .so
Thanks @bddppq for the pointer