Small code refine to avoid unnecessary object copy overhead. #22
Conversation
Signed-off-by: muzhuo.yj <[email protected]>
There was a problem hiding this comment.
@yangjunpro Thanks for the contribution. ConvertGraphToTRTEngine is exposed as an API for the core, so we will need to change the forward declaration in core/compiler.h as well and probably at the same time we should go ahead and change the public api as well in cpp/api/include/trtorch.h and its implementation in cpp/api/src/trtorch.cpp. (linked lines below)
https://github.com/NVIDIA/TRTorch/blob/3da4947c438e78c9cc7d179664b977ce9394d50e/core/compiler.h#L10
https://github.com/NVIDIA/TRTorch/blob/3da4947c438e78c9cc7d179664b977ce9394d50e/cpp/api/include/trtorch/trtorch.h#L242
https://github.com/NVIDIA/TRTorch/blob/3da4947c438e78c9cc7d179664b977ce9394d50e/cpp/api/src/trtorch.cpp#L13
Seems like a worthwhile change so if you can update the PR with those as well and make sure it passes the module tests we should be good to go!
|
This PR has not seen activity for 30 days, Remove stale label or comment or this will be closed in 5 days |
Summary: Pull Request resolved: pytorch/fx2trt#22 Alternative to D34911848 Reviewed By: frank-wei Differential Revision: D34930874 fbshipit-source-id: 0da1081cac09feb188d2624ba04c86d5f3ffef6c
Very small PR as a ramp up.