Skip to content

fix/feat: Add support for multiple TRT Build Args #2510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2023
Merged

fix/feat: Add support for multiple TRT Build Args #2510

merged 1 commit into from
Dec 8, 2023

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Dec 2, 2023

Description

  • Add support in Dynamo path to bring build arg parity to 1-1 with TorchScript
  • Add tests for new build arguments
  • Modify TRT Interpreter and conversion phases accordingly

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive added the WIP Work is in progress, pull request should not be merged yet label Dec 2, 2023
@gs-olive gs-olive self-assigned this Dec 2, 2023
@gs-olive gs-olive requested a review from narendasan December 2, 2023 01:48
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests labels Dec 2, 2023
@github-actions github-actions bot requested a review from peri044 December 2, 2023 01:48
@gs-olive gs-olive force-pushed the dynamo_add_trt_builder_args branch from 338de01 to 07cbb39 Compare December 2, 2023 01:49
github-actions[bot]
github-actions bot approved these changes Dec 2, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Dec 2, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Dec 2, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Dec 2, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Dec 2, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Dec 2, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@gs-olive gs-olive force-pushed the dynamo_add_trt_builder_args branch from 07cbb39 to 23c017a Compare December 2, 2023 02:24
@gs-olive gs-olive requested a review from zewenli98 December 2, 2023 02:24
github-actions[bot]
github-actions bot approved these changes Dec 2, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Dec 2, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Dec 2, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Dec 2, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@gs-olive gs-olive removed the WIP Work is in progress, pull request should not be merged yet label Dec 2, 2023
zewenli98
zewenli98 reviewed Dec 6, 2023
View reviewed changes
@gs-olive gs-olive force-pushed the dynamo_add_trt_builder_args branch from 23c017a to fad9b36 Compare December 6, 2023 00:07
github-actions[bot]
github-actions bot approved these changes Dec 6, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Dec 6, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

zewenli98
zewenli98 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@zewenli98 zewenli98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@gs-olive gs-olive force-pushed the dynamo_add_trt_builder_args branch from fad9b36 to 89a2e04 Compare December 7, 2023 20:46
github-actions[bot]
github-actions bot approved these changes Dec 7, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Dec 7, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@gs-olive
fix/feat: Add support for multiple TRT Build Args
024b48f 
- Add support in Dynamo path to bring build arg parity to 1-1 with
TorchScript
- Add tests for new build arguments
- Modify TRT Interpreter and conversion phases accordingly
- Centralize usage of settings in TRT Interpreter
@gs-olive gs-olive force-pushed the dynamo_add_trt_builder_args branch from 89a2e04 to 024b48f Compare December 8, 2023 00:17
@gs-olive gs-olive merged commit 6338bd5 into main Dec 8, 2023
@gs-olive gs-olive deleted the dynamo_add_trt_builder_args branch December 8, 2023 00:17
github-actions[bot]
github-actions bot approved these changes Dec 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Dec 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

gs-olive added a commit that referenced this pull request Dec 8, 2023
@gs-olive
fix/feat: Add support for multiple TRT Build Args (#2510)
f9dda69
@gs-olive gs-olive mentioned this pull request Dec 8, 2023
Merged
gs-olive added a commit that referenced this pull request Dec 20, 2023
@gs-olive
fix/feat: Add support for multiple TRT Build Args (#2510)
f93a732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zewenli98 zewenli98 zewenli98 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@narendasan narendasan Awaiting requested review from narendasan

@peri044 peri044 Awaiting requested review from peri044

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gs-olive @zewenli98 @facebook-github-bot