feat: Safety Mode for Runtime #2512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: api [Python]
peri044
approved these changes
Dec 5, 2023
gs-olive
force-pushed
the
runtime_safety
branch
3 times, most recently
from
09b01e0 to
cc32a3c
Compare
gs-olive
commented
Dec 6, 2023
gs-olive
force-pushed
the
runtime_safety
branch
2 times, most recently
from
45675d6 to
518e0a6
Compare
- Add safety mode for Torch-TensorRT runtime - Add C++ TorchBind bindings and relevant lambda functions to get and set necessary attributes - Add runtime augmentations to support different modes - Add testing for safe mode settings
- Add support for device checks in the Python Runtime, to mirror those in the C++ runtime - Fix various issues in partitioning and runtime accordingly
gs-olive
force-pushed
the
runtime_safety
branch
from
518e0a6 to
b434aee
Compare
gs-olive
force-pushed
the
runtime_safety
branch
from
b434aee to
60c73d3
Compare
narendasan
reviewed
Dec 7, 2023
| @@ -31,13 +33,13 @@ c10::optional<RTDevice> get_most_compatible_device(const RTDevice& target_device | |||
| if (device.device_name == target_device.device_name) { | |||
| // First priority is selecting a candidate which agrees with the current device ID | |||
| // If such a device is found, we can select it and break out of the loop | |||
| if (device.id == current_device.id && best_match.id != current_device.id) { | |||
| if (device.id == current_device.id) { | |||
There was a problem hiding this comment.
Why are we changing these?
There was a problem hiding this comment.
During review, it was determined that these are not actually necessary conditions. Since the ID of each device is unique on a given machine, it should not be possible that best_match.id == current_device.id at this point in the code, so the check is not needed here.
github-actions
bot
added
the
documentation
gs-olive
force-pushed
the
runtime_safety
branch
from
51a3edb to
94a5995
Compare
narendasan
reviewed
Dec 7, 2023
narendasan
reviewed
Dec 7, 2023
narendasan
approved these changes
Dec 7, 2023
gs-olive
force-pushed
the
runtime_safety
branch
from
94a5995 to
90dc976
Compare
gs-olive
added a commit
that referenced
this pull request
Dec 8, 2023
gs-olive
added a commit
that referenced
this pull request
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Checklist: